Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow and steps submission #130

Open
dpancic opened this issue Nov 16, 2022 · 3 comments
Open

workflow and steps submission #130

dpancic opened this issue Nov 16, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@dpancic
Copy link

dpancic commented Nov 16, 2022

In GitLab by @laureD19 on Nov 16, 2022, 20:29

when creating a workflow and its steps and saving/submitted them, it creates as many workflow entries in the list of draft items, contributed items or moderation queue, as the number of versions created during the workflow creation process.

In other words, if a contributor creates a workflow and two steps, save as draft, they will see 4 times the workflow entry in the "my draft items" screen.
The same happens when the workflow is submitted, and re-accessed by the contributor from the "my contributed item" screen or seen by the moderator from "items to moderate" screen.

Example below form the "my contributed items" screen for a workflow with two steps (only submitted once):
image

also notify @KlausIllmayer @vronk

@laureD19 laureD19 added this to the Q3 milestone Aug 23, 2023
@stefanprobst
Copy link
Contributor

hmm so we actually do get these entries from the backend, e.g. https://sshoc-marketplace-api.acdh-dev.oeaw.ac.at/api/item-search?page=1&order=modified-on&d.status=suggested

question now is if this is caused by doing something wrong in workflow submission, or if this a backend issue.

@laureD19
Copy link
Contributor

some precisions on this one, based on stage item workflow/4tm28G still in suggestion mode.

  • As contributor, I create a workflow with 2 steps and submit it.
    Instead of creating one version of a workflow, it seems that it creates THREE versions of the workflow: one without step, one with one step, one with two steps.
  • As moderator, I see the three versions of this workflow on the moderation queue. In my example: workflow/4tm28G/version/64315 ; workflow/4tm28G/version/64316 and workflow/4tm28G/version/64318

My take on it would indeed be that backend only creates one version of that workflow. But if it is not possible, could frontend only display the latest version on the moderation queue?

notify also @tparkola @KlausIllmayer @mkrzmr

@vronk vronk removed this from the Q3 milestone Oct 9, 2024
@vronk
Copy link
Contributor

vronk commented Oct 9, 2024

pending implementation of SSHOC/sshoc-marketplace-backend#470

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants