Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch imprint from dynamic ACDH-CH service #117

Open
dpancic opened this issue Jul 28, 2022 · 9 comments · May be fixed by #164
Open

Fetch imprint from dynamic ACDH-CH service #117

dpancic opened this issue Jul 28, 2022 · 9 comments · May be fixed by #164
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@dpancic
Copy link

dpancic commented Jul 28, 2022

In GitLab by @KlausIllmayer on Jul 28, 2022, 16:43

This issue was touched in #28 but not further handled.

We have every now and then changes in the signing power section of the imprints at OEAW. Therefore we do have a dynamic imprint service which is located at ACDH-CH and should always deliver the current version of the imprint.

@stefanprobst Do you see a way to integrate this dynamic service into one of the MP pages? I guess that this is not easy done within a page holding different text blocks, like it is now in privacy-police. Maybe we should separate the imprint from this page into a dedicated one (which would also fit better Austrian law), what do you think @laureD19?

@dpancic
Copy link
Author

dpancic commented Jul 28, 2022

In GitLab by @KlausIllmayer on Jul 28, 2022, 17:00

Just a reminder: if we use the dynamic imprint service we need to adapt the values in the redmine issue so that it fits the current text.

@dpancic
Copy link
Author

dpancic commented Jul 29, 2022

In GitLab by @stefanprobst on Jul 29, 2022, 09:02

the acdh imprint service returns html which we could dump as-is into the "Legal notice" section of the "Privacy policy" page (or a dedicated "Imprint" page).

note however that the imprint text also includes sections on "Copyright notice" and "Data privacy notice"- which we may or may not want to adapt.

also needs decision if the imprint section/page can be built statically or not.

@dpancic
Copy link
Author

dpancic commented Jul 29, 2022

In GitLab by @KlausIllmayer on Jul 29, 2022, 17:20

yes, i'm aware about the overhead of the imprint text - i guess the copyright/data privacy can be used. i currently see only a problem with english/german version, as it does not work as expected (it always shows both even if i don't define german). but probably we need to have the german version also present, not sure what Austrian law says about it (i remember something in this direction but not sure). i think this could be also another argument for creating a separate imprint page.

regarding statically build: not sure what do you mean with this remark? if it is about explicitly building a static version of imprint page and doing this again, if we are aware about a change in the imprint, then i'm in favour. it does not need to fetch the data from the acdh-ch-imprint-service for every visit (otherwise, i guess it will not happen that much, that people look at the imprint page, so it could be also fine if we always fetch it). @stefanprobst are these the both options you meant where we need a decision?

@dpancic
Copy link
Author

dpancic commented Jul 30, 2022

In GitLab by @stefanprobst on Jul 30, 2022, 19:11

  • it is possible to only request the english imprint text when setting outputLang query param
  • yes, fetch imprint once at build time (vs. fetch imprint at request time)

@dpancic
Copy link
Author

dpancic commented Aug 1, 2022

In GitLab by @KlausIllmayer on Aug 1, 2022, 15:30

  • thanks for the hint, i was thinking in the wrong direction, the imprint works like the applied link.
  • in this case i'm in favour of fetch imprint once at build time

we still need a decision by @laureD19 if the preference is to have the imprint at the current place or to create a dedicated webpage.

@dpancic
Copy link
Author

dpancic commented Sep 12, 2022

In GitLab by @laureD19 on Sep 12, 2022, 14:52

if it easier to have a dedicated page for the imprint, I don't mind.
So we would have:

  • a new page called "imprint" based on this input automatically updated
  • the current page "privacy policy" cut just before what is currently "legal notice"

The only thing I'm wondering, in order to avoid repetitions between those two pages is the necessity to keep the last section from your imprint, the "data privacy notice" as it is stating, with less details, the same than what we have in the privacy policy. Could we delete this part maybe?

@laureD19
Copy link
Contributor

  • Privacy Policy
  • Imprint > built on acdh content
  • Terms of Use

@stefanprobst
Copy link
Contributor

please review #164

@laureD19 laureD19 added this to the Q4 2023 milestone Nov 15, 2023
@mkrzmr mkrzmr added the enhancement New feature or request label Mar 12, 2024
@mkrzmr
Copy link

mkrzmr commented Mar 12, 2024

@mkrzmr

@laureD19 laureD19 assigned mkrzmr and unassigned stefanprobst Oct 9, 2024
@laureD19 laureD19 modified the milestones: Q4 2023, Q4 2024 Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants