Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate check for actors/externalIds #483

Open
mkrzmr opened this issue Nov 5, 2024 · 1 comment
Open

Duplicate check for actors/externalIds #483

mkrzmr opened this issue Nov 5, 2024 · 1 comment

Comments

@mkrzmr
Copy link
Contributor

mkrzmr commented Nov 5, 2024

While working on an ingest script, I noticed actors can have duplicate externalIds, for example this actor has duplicate entries for GitHub and Twitter:

Each entry will also be shown in the frontend, creating a lot of identical links

I am going to change my script to avoid creating duplicate entries, but it is something to keep in mind - what is the estimate to add a check to this endpoint to avoid duplicate externIds?

{ "id": 3020, "name": "Adam Crymble", "externalIds": [ { "identifierService": { "code": "GitHub", "label": "GitHub", "ord": 4, "urlTemplate": "https://github.com/{source-actor-id}" }, "identifier": "https://github.com/acrymble" }, { "identifierService": { "code": "Twitter", "label": "Twitter", "ord": 5, "urlTemplate": "https://twitter.com/{source-actor-id}" }, "identifier": "https://twitter.com/Adam_Crymble" }, { "identifierService": { "code": "SourceActorId", "label": "Source ActorId", "ord": 7, "urlTemplate": "" }, "identifier": "2-6abc40a103ee9ea16470df510dac897774393bdb2b54fbb066acd0e6e4fc4a07" }, { "identifierService": { "code": "GitHub", "label": "GitHub", "ord": 4, "urlTemplate": "https://github.com/{source-actor-id}" }, "identifier": "acrymble" }, { "identifierService": { "code": "Twitter", "label": "Twitter", "ord": 5, "urlTemplate": "https://twitter.com/{source-actor-id}" }, "identifier": "Adam_Crymble" }, { "identifierService": { "code": "SourceActorId", "label": "Source ActorId", "ord": 7, "urlTemplate": "" }, "identifier": "2-e054591b9e982532467ffc1613578601290b611a81808681e26eaec3748e4093" }, { "identifierService": { "code": "DBLP", "label": "dblp", "ord": 2, "urlTemplate": "https://dblp.org/pid/{source-actor-id}" }, "identifier": "145/8079" }, { "identifierService": { "code": "SourceActorId", "label": "Source ActorId", "ord": 7, "urlTemplate": "" }, "identifier": "103-145/8079" } ], "website": "http://adamcrymble.org", "affiliations": [ { "id": 2902, "name": "University College London", "externalIds": [ { "identifierService": { "code": "SourceActorId", "label": "Source ActorId", "ord": 7, "urlTemplate": "" }, "identifier": "2-861604c6886ab122aa147fb1cab83479b93a509265663a733e19bbd27ab29181" }, { "identifierService": { "code": "ROR", "label": "ROR", "ord": 6, "urlTemplate": "https://ror.org/{source-actor-id}" }, "identifier": "02jx3x895" } ], "affiliations": [] } ] }

@mkrzmr
Copy link
Contributor Author

mkrzmr commented Nov 5, 2024

On hold, looking for better example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant