Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete actors by force should cover affiliations #469

Open
KlausIllmayer opened this issue Oct 9, 2024 · 0 comments
Open

Delete actors by force should cover affiliations #469

KlausIllmayer opened this issue Oct 9, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@KlausIllmayer
Copy link
Contributor

Currently, it is not possible to delete an actor that is an affiliation of other actor(s):

} else if (actorRepository.existsActorByAffiliationActorId(id)) {
throw new IllegalArgumentException("Cannot delete actors that are affiliations of other actors!");
} else {

@tparkola Is there a reason, why we don't delete the affiliations and then the actor if force=true?

This question arose as there is no simple API call to identify which actors are affiliated to an actor. It is therefore not easily possible to identify the actors where the affiliation must be removed so that the affiliation actor in the end can be deleted. Anyway, is this a task that could be done within the delete actor routine if force=true. There are two options to deal with this situation: (1) when deleting an actor with force=true then also delete the affiliations or (2) show somewhere which actors belong to the affiliation actor, e.g. as additional return value of the error message of the mentioned code block.
I prefer option (1).

See for discussion and for examples the issue SSHOC/marketplace-curation#31 - also putting @mkrzmr @laureD19 as watchers.

@KlausIllmayer KlausIllmayer added the enhancement New feature or request label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants