Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules of procedure: issue workflow #398

Open
KlausIllmayer opened this issue May 15, 2023 · 3 comments
Open

Rules of procedure: issue workflow #398

KlausIllmayer opened this issue May 15, 2023 · 3 comments
Assignees

Comments

@KlausIllmayer
Copy link
Contributor

KlausIllmayer commented May 15, 2023

Anyone is invited to create new issues if the topic belongs to backend including API endpoints, database problems, SOLR settings, behavior of the business logic. If it is about design and edit workflows of the frontend, please use the dedicated frontend repository and issue list: https://github.com/SSHOC/sshoc-marketplace-frontend/issues

It is not always easy to understand if an issue relates more to backend or to frontend. Therefore the best approach for a new issue is to put @KlausIllmayer as an Assignee, so that I can give a first reply and also see, if the issue is at the correct place. If not, the issue will be moved to a better fitting repository.

If an issue is identified as relevant for backend, the next step is to forward it to the backend team for further investigation. For this the label "to do" is applied to the issue and one of the backend team is added as new assignee.

Issues that need to be solved as soon as possible because they do block other tasks or are important for the maintenance of the marketplace do get the label "critical". This should give them a priority boost. Additionally, they are communicated on our Slack channel, so that the backend-team is aware about this critical issue. If backend agrees to take over the issue, the issue is applied to a milestone (see next paragraphs on how milestones work)

The list of open issues are discussed in a dedicated meeting and they are prioritized there. We work with the help of milestones, where a milestone stand for a quarter of the year (e.g. milestone Q1 2023 contains issues that should be solved by the backend team until end of March 2023). Based on the available resources, issues are applied to such a milestone. We usually only plan for the next milestone (= the next quarter of the year). Open issues, that are not applied to a milestone, will be discussed in the next meeting. As resources are limited, some issues will need to wait longer than other issues.

If backend team works on an issue, a dedicated branch for this issue is created. After fixing, a pull request to the develop-branch is created and all assignees of the issue should have a look before applying the pull request. After accepting the pull request an automatic deployment on the stage instance is done. The change now can be tested there. To mark this state, the issue moves from label "to do" to label "in review". If the issue still is not solved or follow-up problems are spotted, the label "in review" is now replaced with the label "to do" and in the issue a comment is posted, describing what went wrong. Backend team then will again look into it.

If the tests on stage are fine a pull request to the main-branch is created, an comment is added to the issue and it is closed. The pull request is applied usually on Monday or Tuesday afternoon around 17h, as this means that the production instance gets the new code and a short downtime will happen (and in some cases, the search index needs to be re-created, which takes some hours, where the search is not available - thus the availability should be there again in the morning of the next working day). When testing the deployment on production show that everything went fine, the "in review" label is deleted.

@laureD19
Copy link

documentation. Maybe to add to the Github wiki

@laureD19 laureD19 added this to the Q3 2023 milestone Aug 23, 2023
@laureD19 laureD19 assigned laureD19 and KlausIllmayer and unassigned laureD19 Aug 23, 2023
@KlausIllmayer KlausIllmayer pinned this issue Oct 24, 2023
@KlausIllmayer KlausIllmayer removed this from the Q3 2023 milestone Oct 24, 2023
@laureD19 laureD19 unpinned this issue Feb 20, 2024
@laureD19 laureD19 assigned mkrzmr and unassigned KlausIllmayer Oct 4, 2024
@laureD19
Copy link

laureD19 commented Oct 4, 2024

@mkrzmr to investigate how to create Github repo to generate documentation

@mkrzmr
Copy link
Contributor

mkrzmr commented Oct 7, 2024

https://sshoc.github.io/sshoc-marketplace-documentation/

repo is here, going to add the documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants