CR091: Identification of Initiallload with AllData in ServiceDelivery #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haeckerbaer
requested review from
skinkie,
Aurige,
sgrossberndt,
tim-rivett and
Ulf9
ue71603
reviewed
Oct 26, 2022
xsd/siri.xsd
Outdated
| @@ -361,6 +361,11 @@ Rail transport, Roads and road transport. | |||
| </xsd:annotation> | |||
| <xsd:sequence> | |||
| <xsd:group ref="ServiceDeliveryRequestStatusGroup"/> | |||
| <xsd:element name="AllData" type="xsd:boolean" default="false" minOccurs="0"> | |||
There was a problem hiding this comment.
Christophe: Shouldn't the default be true? In a Response pattern the default should be true.
There was a problem hiding this comment.
need to avoid a default which results in all data being supplied each time. All data should only be sent when requested otherwise it could be very inefficient.
prirey
approved these changes
Apr 10, 2024
SteffenSuhr
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://3.basecamp.com/3256016/buckets/9672657/vaults/5470142736