Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIRI-SX, Attribute "Name" on ActionData #146

Open
TuThoThai opened this issue Jan 17, 2025 · 2 comments
Open

SIRI-SX, Attribute "Name" on ActionData #146

TuThoThai opened this issue Jan 17, 2025 · 2 comments

Comments

@TuThoThai
Copy link
Collaborator

TuThoThai commented Jan 17, 2025

Context: France is currently updating its profile of SIRI with a special focus on SIRI-SX

What we have found:

  • In the XSD, the description of the Structure for ActionData includes 3 attributes that are mandatory (Name, Type, Value)
  • Systems tend to use more Type and Prompt as described below
<siri:PtSituationElement>
  <siri:PublishingActions>
    <siri:PublishToWebAction>
      <!-- ... -->
      <siri:ActionData>
        <siri:Name>often empty</siri:Name>

        <siri:Type>short</siri:Type>
        <siri:Value>uncertain of what to put here</siri:Value>

        <siri:Prompt xml:lang="EN">The train will change rolling stock at Dovre. You will have to change trains at this station.</siri:Prompt>

      </siri:ActionData>
    </siri:PublishToWebAction>
  </siri:PublishingActions>
</siri:PtSituationElement>

Question: would it make sense to have the cardinality of Name changed to 0:1 instead of 1:1, to avoid having this field required but always empty?

If you think it would make sense, I am happy to prepare the PR.

@Aurige
Copy link
Contributor

Aurige commented Jan 21, 2025

I agree with this, of course. I guess that the Value (which is an xsd:any) should not be mandatory either.
We could also take the opportunity of updating ActionData to add an ActionCode to uniquely identify the action in order to ease its tracking on data consumer side.

@TuThoThai
Copy link
Collaborator Author

Thanks for your prompt feedback on this matter @Aurige. I will work on the PR shortly!

TuThoThai added a commit to TuThoThai/SIRI that referenced this issue Feb 20, 2025
TuThoThai added a commit to TuThoThai/SIRI that referenced this issue Feb 25, 2025
Suggestion made by the French group to faciliate tracking of Action on the data consumer side.
Directly refers to this [comment](SIRI-CEN#146 (comment)) on issue SIRI-CEN#146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants