Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properties with UTF-8 BOM encoding not loading #487

Open
4 tasks done
DanArtox opened this issue Oct 11, 2024 · 4 comments
Open
4 tasks done

Properties with UTF-8 BOM encoding not loading #487

DanArtox opened this issue Oct 11, 2024 · 4 comments
Labels
bug Something isn't working confirmed Issue is no longer unverified and is relevant to the mod

Comments

@DanArtox
Copy link

The issue

I add new model to my RP mkb.json and others (look in the logs)...

  • type=item
  • matchItems=minecraft:netherite_sword minecraft:diamond_sword
  • model=./mkb.json
  • nbt.display.Name=iregex:(\u041c\u041a\u0411|MKB)
    mkb.properties

But the model is not displayed in the game. Errors appear in the logs - Unknown condition type "citresewn:type"

At the same time, my model "uzi" with properties:

  • type=item
  • matchItems=minecraft:bow
  • model=./uzi.json
  • nbt.display.Name=Micro-PP
    works great

I understand from the error text that the problem is in the "type" field. But why?..

How to reproduce

ELRP-models.zip

Logs

https://pastebin.com/gbE1jTDM

Checklist

  • I checked the issues(both open and closed) and could not find a duplicate of my issue
  • I am using the latest version of CIT Resewn for my Minecraft version
  • I have disabled Broken Paths and the issue persists
  • I am running the mod using Fabric Loader
@DanArtox DanArtox added bug Something isn't working unverified Requires testing. labels Oct 11, 2024
@HiWord9
Copy link

HiWord9 commented Oct 11, 2024

If u would use sinytra connecter than that is the problem, connector is not officially supported. But checklist says u are using Fabric Loader dn logs also saying Using legacy nbt.display.Name which would not appear in case with connector.
And Im sure that this bit of logs is not helpful, u probably would like to send the whole log file if u want the problem to be resolved.

@DanArtox
Copy link
Author

https://mclo.gs/woWlSKR full logs

@SHsuperCM
Copy link
Owner

The files are encoded with something called "UTF-8 BOM" instead of the normal UTF-8. As a hotfix you can just save the file with a different encoding.
image

Leaving the issue open until I fix the issue where it doesnt load it when it should've.

@SHsuperCM SHsuperCM added confirmed Issue is no longer unverified and is relevant to the mod and removed unverified Requires testing. labels Oct 12, 2024
@SHsuperCM SHsuperCM changed the title Unknown condition type "citresewn:type" Properties with UTF-8 BOM encoding not loading Oct 12, 2024
@DanArtox
Copy link
Author

Yes, it helped me
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed Issue is no longer unverified and is relevant to the mod
Projects
None yet
Development

No branches or pull requests

3 participants