Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post time frame can technically have same start and end time #516

Closed
GElsey55 opened this issue Apr 14, 2024 · 2 comments · Fixed by #532
Closed

Post time frame can technically have same start and end time #516

GElsey55 opened this issue Apr 14, 2024 · 2 comments · Fixed by #532
Assignees
Labels
enhancement New feature or request qa

Comments

@GElsey55
Copy link

While this is all technically correct, it's still confusing for the user as the way it's formatted leads them to believe that this all occurs on the same day.
image

@epadams epadams added the enhancement New feature or request label Apr 14, 2024
@epadams
Copy link
Contributor

epadams commented Apr 14, 2024

Good catch, thanks. If anyone else is confused by this, it means that this is Wednesday from 12:05 to Thursday at 12:05 (within the 24hour limit), but we don't visually display the difference through days. Needs to change anyways in case a post goes overnight into the next day

@epadams epadams added the qa label Apr 14, 2024
@jbytes1027
Copy link
Contributor

I would say just make the max length 23 hrs 59 minutes. If the end time looks less than the first, I don't think it's hard to deduce that its talking about the day after. Adding a second day may make it less readable.

@evan-scales evan-scales self-assigned this Apr 15, 2024
@evan-scales evan-scales linked a pull request Apr 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request qa
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants