Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SF][2.5.0][Table][Function][Expected reply Time: ASAP] The difference of selected rows in table #10500

Open
1 task done
wilson-xu-sap opened this issue Jan 9, 2025 · 5 comments
Labels
2.0 documentation This issue is about wrong documentation TOPIC TBL

Comments

@wilson-xu-sap
Copy link

Describe the bug

https://sap.github.io/ui5-webcomponents-react/v2/?path=/docs/migration-guide--docs
The doc does not mention the change of selected table rows.
In version 1.22, the selected rows have blue and clear selected state, which can be set in TableRow.
https://stackblitz.com/edit/github-xbtmwe-zgqwey?file=src%2FApp.tsx

In 2.5.0, the selected attribute in TableRow has been removed. Instead, TableSelection has been introduced. However, TableSelection has unclear documentation and it seems that it cannot show clear selected state.
https://stackblitz.com/edit/github-yzkhjvse-a7gpuwlp?file=src%2FApp.tsx

Is this a bug or I use it in a wrong way?

Isolated Example

https://stackblitz.com/edit/github-yzkhjvse-a7gpuwlp?file=src%2FApp.tsx

Reproduction steps

No response

Expected Behaviour

No response

Screenshots or Videos

No response

UI5 Web Components for React Version

2.5.0

UI5 Web Components Version

2.5.1

Browser

Edge

Operating System

No response

Additional Context

No response

Relevant log output

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@Lukas742
Copy link
Collaborator

Lukas742 commented Jan 9, 2025

Hi @wilson-xu-sap

I agree, the documentation could be clearer and also there's wrong information regarding the mandatory row-key attribute (documented as key) in selection-mode.

I've edited your example and now it's working as intended: https://stackblitz.com/edit/github-yzkhjvse-axvcpuqe?file=src%2FApp.tsx

  • set the mode to "Single" instead of "None"
  • replaced key with rowKey
  • for testing purpose: added a button that resets the selected state

Hi Colleagues,

could you please take over?
The wrong information regarding the row-key can be found here: https://sap.github.io/ui5-webcomponents/components/TableSelection/

@Lukas742 Lukas742 transferred this issue from SAP/ui5-webcomponents-react Jan 9, 2025
@unazko unazko added documentation This issue is about wrong documentation TOPIC Core 2.0 labels Jan 9, 2025
@unazko
Copy link
Contributor

unazko commented Jan 9, 2025

Hello @SAP/ui5-webcomponents-table,

The visual selection indicators appear with the edited by @Lukas742 sample.
Please check if the TableSelection documentation could be improved according to the description by @wilson-xu-sap and @Lukas742.

Best regards,
Boyan

@wilson-xu-sap
Copy link
Author

Hi @Lukas742 I have noticed this single selection mode before, however, this will introduce radio buttons in table, which is still hugely different from the appearance before. Is there a way to show selected state without introducing radio buttons like version 1?

@DonkeyCo
Copy link
Member

Hi @wilson-xu-sap,

I've created two internal incidents for you:
DINC0385228 - Will address the lacking documentation
DINC0385229 - Will address the single selection issue. We also have a BLI currently, that will revamp the selection API

@simlin simlin changed the title [Bug/Discussion][SF][2.5.0][Table][Function][Expected reply Time: ASAP] The difference of selected rows in table [SF][2.5.0][Table][Function][Expected reply Time: ASAP] The difference of selected rows in table Jan 21, 2025
@simlin
Copy link

simlin commented Jan 21, 2025

Handled as feature request with item FIORITECHP1-32642

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 documentation This issue is about wrong documentation TOPIC TBL
Projects
Status: Planned
Development

No branches or pull requests

5 participants