Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug/Discussion][SF][2.5.0][Table][Function][Expected reply Time: ASAP] Fix the version 1 table or have different tags? #10492

Open
1 task done
wilson-xu-sap opened this issue Jan 8, 2025 · 4 comments

Comments

@wilson-xu-sap
Copy link

Describe the bug

Since table in version 1 is different from that in version 2, some issues in version 1 no longer exist in version 2. However, for those complicated tables, it is hard to migrate to version 2. Then questions come,

  1. Could you make fixes available in v1?
  2. When will you deprecate v2 table?
  3. Could we make table tags different to make two versions co-exist?

Isolated Example

No response

Reproduction steps

No response

Expected Behaviour

No response

Screenshots or Videos

No response

UI5 Web Components for React Version

2.5.0

UI5 Web Components Version

2.5.1

Browser

Edge

Operating System

No response

Additional Context

No response

Relevant log output

Organization

SF

Declaration

  • I’m not disclosing any internal or sensitive information.
@Lukas742
Copy link
Collaborator

Lukas742 commented Jan 8, 2025

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

@Lukas742 Lukas742 transferred this issue from SAP/ui5-webcomponents-react Jan 8, 2025
@unazko
Copy link
Contributor

unazko commented Jan 9, 2025

Hello @SAP/ui5-webcomponents-topic-core,

Could you please review those questions.

Best regards,
Boyan

@pskelin
Copy link
Contributor

pskelin commented Jan 9, 2025

Hi @wilson-xu-sap ,
here is a code snippet with which I was able to change the tag under which one of the tables is registered:

// v2 table is imported and registers the `ui5-table` tag
import "@ui5/webcomponents/dist/Table.js";
// v1 import runs registration which will fail silently because tag is taken
import TableCompat from "@ui5/webcomponents-compat/dist/Table.js";

// change tag
TableCompat._metadata.metadata.tag = "ui5-table-v1"

// run define again to register with new tag
TableCompat.define();

Result in DOM:
Image

you can change the order if you want v2 table to have the new name.

to your questions:

  1. Could you make fixes available in v1?

usually yes, fixes can be made in v1. some of them however are quite complicated and require a full restructuring, hence why v2 table was created - to address hard to fix issues.

  1. When will you deprecate v2 table?

hopefully not in a very long time. v1 table was more of a quick implementation until the complex full implementation can come. v2 is considered feature rich and future proof. keep in mind that it is currently experimental and some APIs can change, also according to your feedback. perhaps @simlin can comment on this better.

  1. Could we make table tags different to make two versions co-exist?

Yes, see the snippet above. Let me know if you have any issues with making it run.

@simlin
Copy link

simlin commented Jan 9, 2025

The plan is to remove the experimental flag of the V2 table soon, depending on incoming changes which might cause incompatibilities. These should be handled first for sure.
The v2 table should be the successor of the first implementation. There is for sure currently no plan for a deprecation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🆕 New
Development

No branches or pull requests

5 participants