Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form]: Complex form items will overflow always with new form component #10473

Closed
1 task done
skowrons opened this issue Jan 3, 2025 · 3 comments · Fixed by #10552
Closed
1 task done

[Form]: Complex form items will overflow always with new form component #10473

skowrons opened this issue Jan 3, 2025 · 3 comments · Fixed by #10552
Labels
bug This issue is a bug in the code Medium Prio released TOPIC Core

Comments

@skowrons
Copy link

skowrons commented Jan 3, 2025

Describe the bug

With the introduction of the new Form component, Toolbars no longer function properly within a FormItem. This limitation prevents us from creating responsive rich input fields. The issue also appears in "simpler" components that rely on basic div tags.

I've included several examples in the StackBlitz project. Each FormItem demonstrates a specific usage scenario from our codebase.

Isolated Example

https://stackblitz.com/edit/github-j3pw8ssg?file=src%2FApp.tsx

Reproduction steps

Expected Behaviour

No response

Screenshots or Videos

Image

UI5 Web Components for React Version

2.5.0

UI5 Web Components Version

2.5.1

Browser

Chrome

Operating System

MacOS

Additional Context

No response

Relevant log output

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@Lukas742
Copy link
Collaborator

Lukas742 commented Jan 7, 2025

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

@Lukas742 Lukas742 transferred this issue from SAP/ui5-webcomponents-react Jan 7, 2025
@unazko unazko added TOPIC Core bug This issue is a bug in the code Medium Prio labels Jan 9, 2025
@unazko
Copy link
Contributor

unazko commented Jan 9, 2025

Hello @SAP/ui5-webcomponents-topic-core,

The issue is reproducible for the ui5-form via the provided sample.

Best regards,
Boyan

nnaydenow added a commit that referenced this issue Jan 15, 2025
If the content of an item exceeds the width of the ui5-form-item, it will overflow. With this change, the content now grows to the width of the ui5-form-item.

Fixes: #10473
@github-project-automation github-project-automation bot moved this from New to Completed in Maintenance - Topic Core Jan 15, 2025
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This issue has been resolved in version v2.7.0-rc.0 🎉

The release is available on v2.7.0-rc.0

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio released TOPIC Core
Projects
Status: Completed
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

4 participants