Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-tab): semantic icon is properly aligned in high contrast themes #10467

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

s-todorova
Copy link
Contributor

fixes: #10455

@s-todorova s-todorova requested a review from a team January 6, 2025 14:07
Copy link
Contributor

@LidiyaGeorgieva LidiyaGeorgieva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • please remove the changes from "..._exp" files
  • in some cases the semantic icon is not vertically centered (with 1-2px). This can be fixed later, in the BLI
  • there is no design for the overflow popover and not sure how the indentation should look. We should request one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ui5-tab]: icon is misaligned in high-contrast themes
2 participants