Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TBI - Allow custom ABAP instances to be filtered during the CF discovery flow #2734

Open
2 tasks
longieirl opened this issue Jan 6, 2025 · 0 comments
Open
2 tasks

Comments

@longieirl
Copy link
Contributor

longieirl commented Jan 6, 2025

Description (include screenshots)

Currently, the CF discovery flow is dependent on the @sap/cf-tools to retrieve a list of ABAP instances based on a predefined and known list, for example;

During the CF flow, as shown below, the user might want to expose other types of ABAP instances that might not be defined using the predefined list as above;

Image

In some instances, customers might want to expose other known service types. To support this, the CF discovery should allow additional service types to be added to the filtered list, for example;

Load from .env file;

ABAPEnvServiceTypes=internal,test

Load from shell;

ABAPEnvServiceTypes="internal,test" node app.js
# or pre-scripting your env variables
export ABAPEnvServiceTypes='internal,test"

Value

Provides an additional way to load ABAP instance types.

Architecture Elaboration

No

Notes

Tasks

  • Read additional service types from process.env
  • Add new unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant