[P2][Sourcing][fd-popover] there is no focus on popover after popover opened

[nancy07-f]

Is this a bug, enhancement, or feature request?

bug

Describe your proposal.

When open popover, should focus on popover box.

Can you handle that on the application side

No

Which versions of Angular and Fundamental Library for Angular are affected? Please, specify the exact version. (If this is a feature request, use current version.)

Angular: 15
ngx core platform: 0.43.17

If this is a bug, please provide steps for reproducing it; the exact components you are using;

Click on the link, show popover, but there's no focus on the popover after popover opened. [focusTrapped]="true" and [focusAutoCapture]="true" both have been added. used fd-popover component.

Please provide relevant source code (if applicable).

<fdp-link *ngIf="linkName" tabindex="0"
          ada-focus ada-setattribute attrSelector="a" attr="data-high-contrast=true"
          (click)="onEditStart($event, itemPopoverDialog, popoverEditType, node, column, currentTerm, terms)"
          [title]="linkName"
          [attr.awname]="linkName">
    {{linkName}}
</fdp-link>
<fd-popover #itemPopoverDialog
            [focusTrapped]="true"
            [focusAutoCapture]="true"
            [noArrow]="false"
            [maxWidth]="600"
            [closeOnOutsideClick]="false"
            [closeOnEscapeKey]="false"
            [fixedPosition]="true"
            [placement]="placement ? placement : 'top-start'"> ....</fd-popover>

Please provide stackblitz example(s).

In case this is Accessibility related topic, did you consult with an accessibility expert? If not, please do so and share their recommendations.

Did you check the documentation and the API?

Did you search for similar issues?

Is there anything else we should know?

it works on 0.43.14.

[droshev]

@nancy07-f Can you answer to all the questions? It will help for faster processing.

[nancy07-f]

@droshev I put some relevant source code. FYI. thanks.

[droshev]

@nancy07-f this seems a regression one

[mikerodonnell89]

@nancy07-f I think we need to see what that onEditStart function is doing. Or, try adding [fdPopoverTrigger]="itemPopoverDialog". This is working fine on 0.43.20 with the following source:

<button fd-button [fdPopoverTrigger]="popover">Popover Trigger</button>

<fd-popover [focusTrapped]="true" [focusAutoCapture]="true" #popover>
    <fd-popover-control>
        <button fd-button label="Sample"></button>
    </fd-popover-control>
    <fd-popover-body>
        <div fd-popover-body-header id="popover-bar-simple-header-2">
            <div fd-bar barDesign="header-with-subheader" [cozy]="true">
                <div fd-bar-left>
                    <fd-bar-element>Cozy Header</fd-bar-element>
                </div>
            </div>
            <div fd-bar barDesign="subheader" [cozy]="true" id="popover-bar-simple-header-3">
                <div fd-bar-middle>
                    <fd-bar-element [fullWidth]="true"
                    >SubHeader Middle section with Full Width Element
                    </fd-bar-element>
                </div>
            </div>
        </div>
        <fd-avatar [circle]="true" style="margin: 1rem" size="xl" glyph="group"></fd-avatar>
        <div fd-popover-body-footer>
            <div fd-bar barDesign="footer" [cozy]="true">
                <div fd-bar-right>
                    <fd-button-bar label="Save" fdType="emphasized"></fd-button-bar>
                    <fd-button-bar label="Cancel"></fd-button-bar>
                </div>
            </div>
        </div>
    </fd-popover-body>
</fd-popover>

Screen.Recording.2023-12-07.at.4.56.32.PM.mov

[nancy07-f]

@mikerodonnell89 can you provide me with the ui link for 0.43.20? I want to test on my side. thanks.

[nancy07-f]

this one can be resolved on my side, so will close it. thanks @droshev @mikerodonnell89 .