[P1][Sourcing] Boolean value is not available in value help dialog component

[sahanaN123]

Is this a bug, enhancement, or feature request? enhancement

Describe your proposal. In Value help dialog component we do not have boolean value filter

Can you handle that on the application side No we cannot

Which versions of Angular and Fundamental Library for Angular are affected? Please, specify the exact version. (If this is a feature request, use current version.)

If this is a bug, please provide steps for reproducing it; the exact components you are using;

Please provide relevant source code (if applicable).

Please provide stackblitz example(s).

In case this is Accessibility related topic, did you consult with an accessibility expert? If not, please do so and share their recommendations.

Did you check the documentation and the API?

Did you search for similar issues?

Is there anything else we should know?

[rvamudha]

s this a bug, enhancement, or feature request? enhancement

Describe your proposal.

In Value help dialog component, we do not have Boolean value filter.

https://sap.github.io/fundamental-ngx/#/platform/value-help-dialog

We have below filter options can not have pre-defined list which can be used in the filter
contains = 'contains'
equalTo = 'equal to'
between = 'between'
startsWith = 'starts with'
endsWith = 'ends with'
lessThan = 'less than'
lessThanEqual = 'less than or equal to'
greaterThan = 'greater than'
greaterThanEqual = 'greater than or equal to'
empty = 'empty'

Can you handle that on the application side?
No we cannot
Which versions of Angular and Fundamental Library for Angular are affected? Please, specify the exact version. (If this is a feature request, use current version.)
Angular 15

If this is a bug, please provide steps for reproducing it; the exact components you are using;
https://sap.github.io/fundamental-ngx/#/platform/value-help-dialog

Please provide relevant source code (if applicable).
Please provide stackblitz example(s).
In case this is Accessibility related topic, did you consult with an accessibility expert? If not, please do so and share their recommendations.
Did you check the documentation and the API?
Did you search for similar issues?
Is there anything else we should know?

[droshev]

The team thinks that Smart filter bar(it support comobobox) with platform table gives the features you are looking for.

[rvamudha]

Selection possible - Yes
Search paramters other than column in the table ( custom filter )- Oscar need to check
Token on the bottom - not available
Currently search options are not working looks like many issues
Pop-up issues for filters ( )
Ux is bit difficult to follow

Value help dialog

Selection possible - Yes
Search parameters with pre-defined values ( combo box / list ) – not possible
Search parameters other than column in the table ( custom filter ) - Not possible
Token on the bottom – Available
Search works - Always with text search only (with different comparison operators)
Pop-up issues for filters ( ) – NA
Ux is better

[droshev]

@rvamudha Currently search options are not working looks like many issues - can you list few?

[droshev]

The requirement: offer comobobox as a input type in the filters. Another one is the data for the filters can come either from the table columns and/or from others. We are waiting for Sourcing team to make a decision whether we should plan it as prio 1 compared to the others.

[rvamudha]

@droshev - as conveyed over our MS teams chat, implementing the workaround / customer solution from Sourcing side is difficult. We will wait for standard solution from F-NGx

[N1XUS]

Agreed solution: add ability to define custom control per each filter type.

[oscargong]

Hi @N1XUS,
I see your PR #11080 for 0.48. Is it possible to include this feature for Fundamental 0.43 (for Angular 15)?

[N1XUS]

Hi @N1XUS, I see your PR #11080 for 0.48. Is it possible to include this feature for Fundamental 0.43 (for Angular 15)?

Hey @oscargong. I will create a PR for ng15 once I get an approval for main

[sahanaN123]

Hi @N1XUS @droshev ,

We tried to implement the dropdown in advanced filters. But we are just getting label and no combo box is displayed. Even we tried using the exact code from the website and still its the same.
https://stackblitz.com/edit/angular-ugca8x-tigsbs?file=src%2Fapp%2Fapp.module.ts
But we observed that on the website we see combo box present again with same code which we used in stackblitz.

Let us know if we need to change anything while implementing at our end.

Thanks,
Sahana.

[N1XUS]

@sahanaN123 https://stackblitz.com/edit/angular-ugca8x-uhmsjb?file=src%2Fapp%2Fapp.module.ts,src%2Fapp%2Fdynamic-page-tabs-example.component.html

it turns out in docs I've applied fd-form-control component to fd-combobox, which is a no-no. I've updated an example in stackblitz and moved fd-form-control outside fd-combobox.