Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P2][Sourcing][Accessibility]tree table : tree nodes should be operable using left and right arrow keys #10261

Closed
I543348 opened this issue Aug 1, 2023 · 7 comments · Fixed by #10480
Assignees
Labels
accessibility use this label for any issue or enhancement related to screenreader/keyboard/etc support ng15 Angular 15 support table

Comments

@I543348
Copy link

I543348 commented Aug 1, 2023

Is this a bug, enhancement, or feature request?

Bug

Briefly describe your proposal.

As per w3 standards, tree nodes should be expandable or collapsible using left and right arrow keys, and also using the same set of keys to traverse between table cells

Which versions of Angular and Fundamental Library for Angular are affected? (If this is a feature request, use current version.)

Angular 15
0.43.0-rc.16

If this is a bug, please provide steps for reproducing it.

replicable on https://sap.github.io/fundamental-ngx/#/platform/table/basic#tree

Please provide relevant source code if applicable.

Is there anything else we should know?

please see keyboard support in https://www.w3.org/WAI/ARIA/apg/patterns/treegrid/examples/treegrid-1/

@droshev droshev added ng15 Angular 15 support table accessibility use this label for any issue or enhancement related to screenreader/keyboard/etc support labels Aug 17, 2023
@droshev droshev changed the title [Sourcing][Accessibility] tree table : tree nodes should be operable using left and right arrow keys [Sourcing][Accessibility][Sep] tree table : tree nodes should be operable using left and right arrow keys Aug 17, 2023
@droshev
Copy link
Contributor

droshev commented Aug 17, 2023

ng15

@droshev droshev changed the title [Sourcing][Accessibility][Sep] tree table : tree nodes should be operable using left and right arrow keys [Sourcing][Accessibility][Sep15] tree table : tree nodes should be operable using left and right arrow keys Aug 17, 2023
@droshev droshev changed the title [Sourcing][Accessibility][Sep15] tree table : tree nodes should be operable using left and right arrow keys [Sourcing][Accessibility][Sep18] tree table : tree nodes should be operable using left and right arrow keys Aug 17, 2023
@droshev droshev changed the title [Sourcing][Accessibility][Sep18] tree table : tree nodes should be operable using left and right arrow keys [Sourcing][Accessibility]tree table : tree nodes should be operable using left and right arrow keys Aug 27, 2023
@rvamudha rvamudha changed the title [Sourcing][Accessibility]tree table : tree nodes should be operable using left and right arrow keys [2][Sourcing][Accessibility]tree table : tree nodes should be operable using left and right arrow keys Aug 30, 2023
@droshev droshev assigned g-cheishvili and unassigned N1XUS Aug 30, 2023
@fkolar fkolar changed the title [2][Sourcing][Accessibility]tree table : tree nodes should be operable using left and right arrow keys [P2][Sourcing][Accessibility]tree table : tree nodes should be operable using left and right arrow keys Aug 31, 2023
@droshev droshev closed this as completed Sep 8, 2023
@droshev
Copy link
Contributor

droshev commented Sep 11, 2023

fixed with 0.43.8

@sagar7259
Copy link

Hello,
This issue is still not fixed has the tree nodes cannot be opened using left/right arrow keys and this needs to be fixed.

@rvamudha please reopen this ticket.

Regards,
Sagar

@g-cheishvili
Copy link
Contributor

Hello, This issue is still not fixed has the tree nodes cannot be opened using left/right arrow keys and this needs to be fixed.

@rvamudha please reopen this ticket.

Regards, Sagar

What do you mean it is not working?

tree_opening.mov

@droshev
Copy link
Contributor

droshev commented Sep 20, 2023

Hello, This issue is still not fixed has the tree nodes cannot be opened using left/right arrow keys and this needs to be fixed.

@rvamudha please reopen this ticket.

Regards, Sagar

@sagar7259 which version did you test with?

@sagar7259
Copy link

Hi Team,

The issue is fixed with version 0.43.8, hence this ticket can be closed.

Regards,
Sagar

@droshev
Copy link
Contributor

droshev commented Nov 10, 2023

@I543348 We would need to remove the row focus as per recommendation from our a11y experts. In that page this is just an example. (treegrid example shows a row focus. The grid examples don’t) - related to issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility use this label for any issue or enhancement related to screenreader/keyboard/etc support ng15 Angular 15 support table
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants