Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace DICOMweb test services in pixl_core unit tests with mocks #383

Open
3 tasks
milanmlft opened this issue Apr 30, 2024 · 0 comments
Open
3 tasks

Replace DICOMweb test services in pixl_core unit tests with mocks #383

milanmlft opened this issue Apr 30, 2024 · 0 comments
Labels
dev-velocity Working on the issue will increase development speed in the long run
Milestone

Comments

@milanmlft
Copy link
Member

milanmlft commented Apr 30, 2024

Definition of Done / Acceptance Criteria

The orthanc and dicomweb-server services currently defined in pixl_core/tests/docker-compose.yml have been removed and replaced by mock services in the unit tests.

Testing

  • the current pixl_core/uploader/test_dicomweb.py tests should still pass

Documentation

  • Document mock services using appropriate docstrings
  • Update pixl_core/README.md

Dependencies

No response

Details and Comments

The test services were added in #379 but are duplicated across pixl_core/ and the system test (test/), which is not ideal. In addition, having to spin up the Docker containers to run the pixl_core unit tests is a pain. Ideally we'd want to spin up the services only for the system test.

@milanmlft milanmlft added the dev-velocity Working on the issue will increase development speed in the long run label Apr 30, 2024
@milanmlft milanmlft added this to the VOXL milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-velocity Working on the issue will increase development speed in the long run
Projects
None yet
Development

No branches or pull requests

1 participant