Kcgallagher bugfix default workflows 268 #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KCGallagher
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #270 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 110 110
Lines 3865 3876 +11
=========================================
+ Hits 3865 3876 +11 ☔ View full report in Codecov by Sentry. |
I-Bouros
approved these changes
Aug 6, 2024
rccreswell
requested changes
Aug 6, 2024
|
@KCGallagher Theres a typo but I didnt submit my review before it got merged: #271 is where i moved the suggestions Thanks for fixing so promptly |
Merged
|
Thanks for these suggestions Richard - I have approved the new PR where you make these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolving bugs identified in #268. Initial attempts to clean up examples directory (as detailed in #269), however this is a longer project and I want to push this bugfix so that external users can work with the code.
No major functionality changes. Key bugs resolved:
Subsequently also had to update node versions for github actions. Updated all from python 3.8 -> 3.11 simultaneously.
Fixes #268.