New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visible TokenExchangeRequestValidator fail message #2

Open

EgorTarasovSecurrency opened this issue Aug 31, 2022 · 0 comments

EgorTarasovSecurrency commented Aug 31, 2022

Currently, TokenExchangeRequestValidator fail message is effectively lost since it is exchanged to the generic message

TokenExchange/src/Rsk.TokenExchange.IdentityServer4/TokenExchangeExtensionGrantValidator.cs

Line 70 in b999e77

    
           context.Result = new GrantValidationResult(TokenRequestErrors.InvalidGrant, "Invalid subject token");

It would be nice to make the error description visible. Perhaps, something like that:

context.Result = new GrantValidationResult(TokenRequestErrors.InvalidGrant, $"Invalid subject token - {validationResult.ErrorDescription}");

If you will accept PRs on the change, please let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment