From f83b0249c5b62a3dbffe28b9b4af7f92081d704b Mon Sep 17 00:00:00 2001 From: Maciej Majek Date: Mon, 9 Sep 2024 09:19:20 +0200 Subject: [PATCH] refactor(hmi_node.py): extract status_publisher_timer_period_sec variable for better readability and maintainability refactor(tts_node.py): extract status_publisher_timer_period_sec variable for better readability and maintainability --- src/rai_hmi/rai_hmi/hmi_node.py | 5 ++++- src/rai_tts/rai_tts/tts_node.py | 4 +++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/rai_hmi/rai_hmi/hmi_node.py b/src/rai_hmi/rai_hmi/hmi_node.py index 79262c31c..d470b0861 100755 --- a/src/rai_hmi/rai_hmi/hmi_node.py +++ b/src/rai_hmi/rai_hmi/hmi_node.py @@ -81,8 +81,11 @@ def __init__(self): String, "to_human", 10, callback_group=self.callback_group ) + status_publisher_timer_period_sec = 0.25 self.create_timer( - 0.25, self.status_callback, callback_group=self.callback_group + status_publisher_timer_period_sec, + self.status_callback, + callback_group=self.callback_group, ) self.status_publisher = self.create_publisher(String, "hmi_status", 10) # type: ignore diff --git a/src/rai_tts/rai_tts/tts_node.py b/src/rai_tts/rai_tts/tts_node.py index f2715dd69..c2901ae14 100644 --- a/src/rai_tts/rai_tts/tts_node.py +++ b/src/rai_tts/rai_tts/tts_node.py @@ -53,7 +53,9 @@ def __init__(self): self.job_id: int = 0 self.queued_job_id = 0 self.tts_client = self._initialize_client() - self.create_timer(0.25, self.status_callback) + + status_publisher_timer_period_sec = 0.25 + self.create_timer(status_publisher_timer_period_sec, self.status_callback) threading.Thread(target=self._process_queue).start() self.get_logger().info("TTS Node has been started") # type: ignore self.threads_number = 0