Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer Package Generator Status #23

Open
mhallerud opened this issue Apr 28, 2020 · 1 comment
Open

Layer Package Generator Status #23

mhallerud opened this issue Apr 28, 2020 · 1 comment

Comments

@mhallerud
Copy link
Contributor

A layer package generator has been added to the RCAT toolbox, however the following should be noted:

  • Vegetation layers are based on input rasters, so they will not show adjustments for large river and dredge tailing polygons and slightly misrepresents what we actually use to calculate RVD/RCA.
  • If we were to change the vegetation layers be based on intermediate rasters, the layers would be limited to the valley bottom extent because this is how the intermediates are generated. My guess is that this covers the whole watershed in most cases, but for Upper Salmon at least, there is a chunk of the watershed area not included. This should not be an issue for the calculations, but might look weird to users.
  • The make_layer functions are working for all tools except for the RCATProject tool. On my machine, I am getting a system error when the script tries to copy the DEM and precipiation rasters into the project folder. I'm not sure if this is just on my machine or is going to cause issues for others, but I have not made any progress trying to fix it. For the time being, I put a "try/except"" statement around the offending code blocks and instructed users to manually copy the rasters into the proper folder(s).
  • Documentation needs to be added for the layer package generator on the website and once bugs are fixed a new release might be warranted.
@wally-mac
Copy link

@tyler1218hatch and @DylanBaum these issues that Maggie brings up still need to be addressed. Once we get to the point of generating LayerPackage we'll need to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants