From 5ea246b063f87d983ad19995cab82dd07704d5c6 Mon Sep 17 00:00:00 2001 From: Siddharth Mishra Date: Fri, 20 Dec 2024 09:48:54 +0530 Subject: [PATCH] `FREE` Automatically Sets To `NULL` No need to explicitly sets variables to `NULL` after using `FREE` on them, this is automatically done in `FREE` macro --- Include/Reai/Util/CStrVec.h | 1 - Include/Reai/Util/Vec.h | 2 +- Source/Reai/Api/Reai.c | 2 -- Source/Reai/Api/Response.c | 1 - Source/Reai/ApiError.c | 2 -- 5 files changed, 1 insertion(+), 7 deletions(-) diff --git a/Include/Reai/Util/CStrVec.h b/Include/Reai/Util/CStrVec.h index b66dd82..ebbe8cd 100644 --- a/Include/Reai/Util/CStrVec.h +++ b/Include/Reai/Util/CStrVec.h @@ -50,7 +50,6 @@ extern "C" { RETURN_VALUE_IF (!clone || !*clone, (CString *)NULL, ERR_INVALID_ARGUMENTS); FREE (*clone); - *clone = (CString)NULL; return clone; } diff --git a/Include/Reai/Util/Vec.h b/Include/Reai/Util/Vec.h index 2a339cd..e06a652 100644 --- a/Include/Reai/Util/Vec.h +++ b/Include/Reai/Util/Vec.h @@ -151,7 +151,7 @@ extern "C" { memmove ( \ vec->items + index, \ vec->items + index + 1, \ - sizeof (vec_itype) * (vec->length - index - 1) \ + sizeof (vec_itype) * (vec->count - index - 1) \ ); \ vec->count--; \ \ diff --git a/Source/Reai/Api/Reai.c b/Source/Reai/Api/Reai.c index 8c53a38..1691703 100644 --- a/Source/Reai/Api/Reai.c +++ b/Source/Reai/Api/Reai.c @@ -154,12 +154,10 @@ void reai_destroy (Reai* reai) { if (reai->host) { FREE (reai->host); - reai->host = NULL; } if (reai->api_key) { FREE (reai->api_key); - reai->api_key = NULL; } FREE (reai); diff --git a/Source/Reai/Api/Response.c b/Source/Reai/Api/Response.c index 6dd6620..9c66d1f 100644 --- a/Source/Reai/Api/Response.c +++ b/Source/Reai/Api/Response.c @@ -794,7 +794,6 @@ HIDDEN ReaiResponse* reai_response_reset (ReaiResponse* response) { case REAI_RESPONSE_TYPE_RENAME_FUNCTION : { if (response->rename_function.msg) { FREE (response->rename_function.msg); - response->rename_function.msg = NULL; } } diff --git a/Source/Reai/ApiError.c b/Source/Reai/ApiError.c index 0b6259d..bd4bbe4 100644 --- a/Source/Reai/ApiError.c +++ b/Source/Reai/ApiError.c @@ -46,12 +46,10 @@ ReaiApiError* reai_api_error_clone_deinit (ReaiApiError* clone) { if (clone->code) { FREE (clone->code); - clone->code = NULL; } if (clone->message) { FREE (clone->message); - clone->message = NULL; } return clone;