Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak in ServerRfSessionImpl #125

Open
ddijak opened this issue Jan 12, 2018 · 1 comment
Open

Memory leak in ServerRfSessionImpl #125

ddijak opened this issue Jan 12, 2018 · 1 comment

Comments

@ddijak
Copy link

ddijak commented Jan 12, 2018

@OverRide
public void sendAccountAnswer(RfAccountingAnswer accountAnswer) throws InternalException, IllegalStateException, RouteException, OverloadException {
try {
session.send(accountAnswer.getMessage());
/* TODO: Need to notify state change...
if (isStateless() && isValid()) {
session.release();
}
*/
}
catch (IllegalDiameterStateException e) {
throw new IllegalStateException(e);
}
}

After sending the answer, the sessions never gets released (beacuse its commented) and it causes memory leak in the long run.

@gsaslis
Copy link
Contributor

gsaslis commented Jan 25, 2018

Hi @Skymania ! 👋
Thanks for raising the issue!

Would you like to have a go at submitting a Pull Request for fixing this issue?
If you need any help on the process, our Open Source Playbook might be of some help.

Please let me know if there's anything else you need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants