add linearizedproductof to lowprioritycandidates for sample list form constraint

[wouterwln]

See #340 for an explanation for this PR

[bvdmitri]

Perhaps this PR can also add ProductOf to the list?

[wouterwln]

ProductOf is covered by :

RxInfer.jl/src/constraints/form/form_sample_list.jl

Lines 72 to 76 in 318bd43

	function ReactiveMP.constrain_form(constraint::SampleListFormConstraint, product::ProductOf)
	left = ReactiveMP.constrain_form(constraint, BayesBase.getleft(product))
	right = ReactiveMP.constrain_form(constraint, BayesBase.getright(product))
	return __approximate(constraint, left, right)
	end

We can add it to the list if you want, but I don't think it will ever be called.

[bvdmitri]

I also wonder why this error message hasn't been showed in the #340 , perhaps the logic can be improved to guide users towards LeftProposal/RightProposal

[bvdmitri]

ProductOf is covered by

Here it isn’t, because you can have a ProductOf{T, ProductOf{A,B}} in the same way as ProductOf{T,LinearizedProductOf{A}}

[wouterwln]

But it will be covered since that function is recursive

[bvdmitri]

In any case, the PR is good, can be merged as is, my comments are more about further potential improvements

[bvdmitri]

But it will be covered since that function is recursive

ah, you are right, my bad

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.75%. Comparing base (04ea9fc) to head (44b9e49).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #341   +/-   ##
=======================================
  Coverage   84.75%   84.75%           
=======================================
  Files          19       19           
  Lines        1502     1502           
=======================================
  Hits         1273     1273           
  Misses        229      229           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.