Initial integration with ExponentialFamilyProjection #325
+1,022
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for comments @albertpod , all of them have been addressed |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
==========================================
+ Coverage 84.64% 84.75% +0.10%
==========================================
Files 18 19 +1
Lines 1472 1502 +30
==========================================
+ Hits 1246 1273 +27
- Misses 226 229 +3 ☔ View full report in Codecov by Sentry. |
Nimrais
reviewed
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
ExponentialFamilyProjectioninRxInfer.jl. It introduces two new sections on running inference in non-conjugate models and handling factor nodes without explicitly defined message update rules.This PR is accompanied by a corresponding PR to
RxInfer.jl. Tests for individual rules are available inReactiveMP, and this PR includes tests for the overall inference procedure.