Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc update on FullFactorisation following its name change to BetheFactoridation #237

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

Raphael-Tresor
Copy link
Contributor

@Raphael-Tresor Raphael-Tresor commented Mar 6, 2024

Change on page /docs/src/manuals/model-specification part ####Factorisation-constraint-option :

  • Replace FullFactorisation by BetheFactorisation every where in the documentation.

  • On the same part /1. MeanField() ,add the word "naive" to "mean field" for it to create no confusion with the generalised mean field

@Raphael-Tresor Raphael-Tresor requested a review from bvdmitri March 6, 2024 09:08
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 79.42%. Comparing base (495baa7) to head (6b0cdc1).

Files Patch % Lines
src/graphppl.jl 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
- Coverage   80.32%   79.42%   -0.90%     
==========================================
  Files          11       11              
  Lines        1291     1293       +2     
==========================================
- Hits         1037     1027      -10     
- Misses        254      266      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bvdmitri
Copy link
Member

bvdmitri commented Mar 6, 2024

Hey @Raphael-Tresor , thanks for taking over this. Please take a look at this guide to test this change together with the dev-ed version of ReactiveMP (basically you need to use make devtest for that, but first you need to ] dev all the core packages, let me know if you have an issue with that)

@bvdmitri
Copy link
Member

Thanks @Raphael-Tresor !

@bvdmitri bvdmitri merged commit 0bd5a60 into main Mar 18, 2024
5 of 7 checks passed
@bvdmitri bvdmitri deleted the betheFactorisationDoc branch March 18, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants