Fix missing check for infer function #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #228 +/- ##
==========================================
+ Coverage 80.31% 80.32% +0.01%
==========================================
Files 11 11
Lines 1290 1291 +1
==========================================
+ Hits 1036 1037 +1
Misses 254 254 ☔ View full report in Codecov by Sentry. |
bvdmitri
reviewed
Feb 22, 2024
test/inference_test.jl
Outdated
| observations = [[1.0; zeros(5)], [zeros(5); 1.0]] | ||
|
|
||
| @testset "Test misspecified data" begin | ||
| @test_throws ErrorException infer(model = rolling_die(2), data = (y = observations)) |
There was a problem hiding this comment.
These tests don't really test that the output error is user friendly. It will error of course anyway no matter the changes in the PR. I suggest to use
@test_throws "part of the error message" infer(...)
See example here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have noticed a missing check for the
datain theinferfunction.Fixed now. Added a few more tests.