Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic save backups are screwed a bit by the latest patch (209.9) #39

Open
BishopIngold opened this issue Jun 20, 2022 · 10 comments
Open

Comments

@BishopIngold
Copy link

With the way the new patch changed the general folder settings for Valheim, and Valheim dedicated servers, Save Shield is no longer correctly recognizing the directory structure.

@Razzmatazzz
Copy link
Owner

Oof, yeah that patch will require some adjustments for sure. Now that Valheim uses Steam's cloud save feature, is this app still as needed?

@BishopIngold
Copy link
Author

I would say yes, as the cloud save overwrites each time, instead of saving the incremental backups.

@pitsch
Copy link

pitsch commented Jun 22, 2022

the incremental backup and selective restore became indispensable for a relaxed playstyle, makes little sense to go back to the game without it, celebrating mid summer night with gravestones and deskilling.

@Razzmatazzz
Copy link
Owner

I don't currently have the game installed and have limited capacity to work on this right now, so I'm not sure when I'll be able to get to it. But I'm happy to merge a PR from someone that fixes the issue and then release a new version.

@sn0rkle
Copy link

sn0rkle commented Jul 6, 2022

Hi @Razzmatazzz,

I have been looking into this and the only change is that the world and character folders now have "_local" appended to the end of them, so we need to look in "characters_local" and "worlds_local".

Ive been through and added _local to the literal strings which were folder paths and not the "type", i also appended it where Type was being used to derive the path. I must have missed something though as its still throwing an expectation somewhere around checking for a backup.

I am going to try and figure it out, but given you know the code and its just a folder name change, i thought i would let you know.

M

@sn0rkle
Copy link

sn0rkle commented Jul 6, 2022

Its having an issue as the backup folder with the name of the character/world is not being created, no idea why.

@sn0rkle
Copy link

sn0rkle commented Jul 7, 2022

I think i have submitted a couple of pull requests to fix the issue, i am a total git n00b, so fingers crossed!

@sn0rkle
Copy link

sn0rkle commented Jul 7, 2022

Also release here for the impatient: https://github.com/sn0rkle/ValheimSaveShield

@MonolithTMA
Copy link

@sn0rkle It works perfectly, thank you!

@Razzmatazzz
Copy link
Owner

Whoops, I thought that fix was included in the last release, but I guess not. Just pushed a new version that includes it this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants