Not using mode when redeploying

[atpcln]

Describe the bug
When re-deploying policies spliited deployment, mode is not used.
When policy initially is deployed mode is set to all, this setting is not used when redeployed.

In the DeploySplittedPolicyDefinition.ps1 i found the following contruct:
if($policy){
Write-Output "Policy '$Name' exists and will be updated."
$policy = Set-AzureRmPolicyDefinition @scope @policyParameter

}else{
Write-Output "Policy '$Name' does not exist and will be created."
$policyParameter.Mode = $Mode
$policy = New-AzureRmPolicyDefinition @scope @policyParameter

}

I think mode is not set, when policy exists?

[SebastianSchuetze]

They. Thanks for posting.

The reason it is not set on redeployment is, because the cmdlet Set-AzureRmPolicyDefinition does not support the parameter "Mode" in version 5.7.0 for AzureRM. And at the time of writing the agents did not support a newer Version.

I need to check, how I can improve this.

[atpcln]

Thanks for clarifying…we reaaly enjoy this task in our pipelines.

…

________________________________ Fra: Sebastian Schütze <[email protected]> Sendt: Monday, September 30, 2019 11:20:31 AM Til: RazorSPoint/azure-devops-azure-policy-extension <[email protected]> Cc: atpcln <[email protected]>; Author <[email protected]> Emne: Re: [RazorSPoint/azure-devops-azure-policy-extension] Not using mode when redeploying (#10) They. Thanks for posting. The reason it is not set on redeployment is, because the cmdlet Set-AzureRmPolicyDefinition does not support the parameter "Mode" in version 5.7.0 for AzureRM<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.microsoft.com%2Fen-us%2Fpowershell%2Fmodule%2Fazurerm.resources%2Fset-azurermpolicydefinition%3Fview%3Dazurermps-5.7.0&data=02%7C01%7C%7C3062c12dd62243e3fb5f08d745877173%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637054320328704796&sdata=Ja%2BXNe%2BZ3OYZ6TnYRPUrUR5%2FdpAI5pTtKU67uIl0%2Bx0%3D&reserved=0>. And at the time of writing the agents did not support a newer Version. I need to check, how I can improve this. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FRazorSPoint%2Fazure-devops-azure-policy-extension%2Fissues%2F10%3Femail_source%3Dnotifications%26email_token%3DAGM26EXHEOR5KE7HOWUE4F3QMHAF7A5CNFSM4I3RV6LKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD75AF4A%23issuecomment-536478448&data=02%7C01%7C%7C3062c12dd62243e3fb5f08d745877173%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637054320328714801&sdata=4RK6Wf1ly8NsA9kF0GF%2Byyf%2F%2BPYaMJFeg6aLrZ%2Fj6n0%3D&reserved=0>, or mute the thread<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAGM26EWFW3PGHPDLVE5KZSLQMHAF7ANCNFSM4I3RV6LA&data=02%7C01%7C%7C3062c12dd62243e3fb5f08d745877173%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637054320328724812&sdata=jh4Mcy35NWf9%2FLH7UPy8KdMFufFh6dqPVJSPkOf9Ng0%3D&reserved=0>.

[SebastianSchuetze]

Thanks! Maybe you can give it a rating if you like it. :-D
But I will check if I can convert it to the Az module for the next version.

Do you have any improvement ideas that you would like to have?

[atpcln]

Hi Sebastian I gave you a five star rating 🙂 And thanks for getting back to me. As improvement, it would be nice if your task would be able to assign the deployments. Kind regards Claus Nielsen

…

________________________________ From: Sebastian Schütze <[email protected]> Sent: Monday, September 30, 2019 10:39 PM To: RazorSPoint/azure-devops-azure-policy-extension <[email protected]> Cc: atpcln <[email protected]>; Author <[email protected]> Subject: Re: [RazorSPoint/azure-devops-azure-policy-extension] Not using mode when redeploying (#10) Thanks! Maybe you can give it a rating if you like it. :-D But I will check if I can convert it to the Az module for the next version. Do you have any improvement ideas that you would like to have? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FRazorSPoint%2Fazure-devops-azure-policy-extension%2Fissues%2F10%3Femail_source%3Dnotifications%26email_token%3DAGM26EQP6T26D5PPXZ2H2NLQMJPXPA5CNFSM4I3RV6LKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD77APJI%23issuecomment-536741797&data=02%7C01%7C%7C2fbff2ad5ed7425c69d508d745e645e7%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637054727618934633&sdata=BMKb9LqMfmpMvvNgWg84FZvaNG8MQv2giOpyo1WlhGE%3D&reserved=0>, or mute the thread<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAGM26EQCN6FO2BCB6XE4F2LQMJPXPANCNFSM4I3RV6LA&data=02%7C01%7C%7C2fbff2ad5ed7425c69d508d745e645e7%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637054727618944644&sdata=7oTo8g8QXBsy8MGFBjbfKnNy9kd7pf8mqhj2qQy4960%3D&reserved=0>.

[SebastianSchuetze]

Currently updating(PR: #12) the extension to support the Az module instead of AzureRM. Also splitting up definitions and initiatives.