Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to send to Assets! rather than just addresses #82

Open
corviato1 opened this issue Dec 24, 2020 · 34 comments
Open

Add the ability to send to Assets! rather than just addresses #82

corviato1 opened this issue Dec 24, 2020 · 34 comments
Labels
gitcoin_funded Funded by gitcoin

Comments

@corviato1
Copy link

Title explains it all, going to make a gitcoin bounty for 0.3 ETH and encourage others to donate to this cause, it will add so much value to asset names. If this works, I will do another bounty for incoming RVN and memos to list all of the Asset! name of the sender for much more $$ and by then I hope this second bounty gains more traction with the community

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.3 ETH (173.69 USD @ $578.98/ETH) attached to it.

@gitcoinbot
Copy link

gitcoinbot commented Feb 10, 2021

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 265 years, 9 months from now.
Please review their action plans below:

1) yorksvit has applied to start work (Funders only: approve worker | reject worker).

how can i withdraw t-bone oral funds to my wallet
2) surajsingla333 has been approved to start work.

Hello, I have been working in the blockchain field for the past 2 years and would like to contribute to the project. It will be a great feature if it can be implemented. Currently, I can think of adding a feature in the asset's smart contract to make the functionality and will start with the same approach. We can discuss more about this, to get to a common understanding and make it happen.
3) thisispalash has been approved to start work.

Hi, I am highly interested in this project. Seems quite doable. I have one question, are you looking for a good UI too? Because if so, I might need to set up Android Studio and everything.

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@thisispalash Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@thisispalash
Copy link

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Yes, I am working on this issue. Right now I'm still trying to figure out the environment and am getting the following error when I build the project,

Execution failed for task ':app:processRvnTestnetDebugGoogleServices'.
> No matching client found for package name 'com.ravenwallet'

I am presuming that this is because of the applicationId of productFlavors.rvnTestnet is "com.ravenwallet". I am not sure how to fix this, I've already reinstalled the project, Android Studio and firebase.
Also, the firebase SDK installation says to use google-services:4.3.5 and not google-services:4.2.0 as in the repo. Should I update?

Finally, what is the timeline you guys are looking at? Since classes have started at uni, I was thinking ~2-3 weeks. Hence, escalation as well.

@gitcoinbot
Copy link

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@TronBlack
Copy link
Contributor

I think testnet is wired up to some Cloud-based diagnostic services. The ravenwallet.com domain belongs to a previous developer on the project (Roshii). He’s now working on an API-based wallet with RVN and Ravencoin asset support ( Stibits)

@corviato1
Copy link
Author

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Yes

@gitcoinbot
Copy link

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@thisispalash Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@thisispalash Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@thisispalash
Copy link

@thisispalash Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

yes.

I think testnet is wired up to some Cloud-based diagnostic services. The ravenwallet.com domain belongs to a previous developer on the project (Roshii). He’s now working on an API-based wallet with RVN and Ravencoin asset support ( Stibits)

ok, so what should I replace the applicationID with? All the different build variants are still failing.
here's the code for easy reference -

productFlavors {
        rvn {
            applicationId = "com.ravenwallet"
            dimension "mode"
            resValue "string", "app_name", "RVN Wallet"
            buildConfigField "boolean", "TESTNET", "false"

            externalNativeBuild {
                cmake {
                    // When you specify a version of CMake, as shown below,
                    // the Android plugin searches for its binary within your
                    // PATH environmental variable.
                    cFlags ""
                    targets "core"
                }
            }
        }

        rvnTestnet {
            applicationId = "com.ravenwallet"
            dimension "mode"
            resValue "string", "app_name", "RVN-testnet"
            buildConfigField "boolean", "TESTNET", "true"

            externalNativeBuild {
                cmake {
                    // When you specify a version of CMake, as shown below,
                    // the Android plugin searches for its binary within your
                    // PATH environmental variable.
                    cFlags "-DTESTNET=1"
                    targets "core"
                }
            }

        }

    }

@gitcoinbot
Copy link

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@corviato1
Copy link
Author

corviato1 commented Feb 19, 2021 via email

@thisispalash
Copy link

thisispalash commented Feb 21, 2021

Ok, so I got the app to build. Turns out I had to change the applicationID in the app gradle to my applicationID from firebase rip. Sorry first time using Android Studio and Firebase.

I have another question, how do I enter the testnet on the app and is there a faucet so I can try some things with some raven? Right now, I am unable to do anything as my wallet is empty.

Also, I am a little confused with the issue. As I understand it currently, you want to be able to send to an asset name instead of an address. So, If I create an asset called iykyk, a smart contract address is generated and others can send to this address. But you want them to be able to send them directly to iykyk?

@gitcoinbot
Copy link

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@thisispalash Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

@thisispalash Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@thisispalash due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@thisispalash due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@thisispalash
Copy link

Hi, I'm sorry but I have to drop this bounty due to communication gaps.

@gitcoinbot
Copy link

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

4 similar comments
@gitcoinbot
Copy link

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@TronBlack
Copy link
Contributor

Ok, so I got the app to build. Turns out I had to change the applicationID in the app gradle to my applicationID from firebase rip. Sorry first time using Android Studio and Firebase.

I have another question, how do I enter the testnet on the app and is there a faucet so I can try some things with some raven? Right now, I am unable to do anything as my wallet is empty.

Also, I am a little confused with the issue. As I understand it currently, you want to be able to send to an asset name instead of an address. So, If I create an asset called iykyk, a smart contract address is generated and others can send to this address. But you want them to be able to send them directly to iykyk?

There are no smart contracts in Ravencoin.
You should check with the author of this issue, but it might mean that they would like a way to send to the address that holds the admin token for an asset. When an asset is created, there is a single admin token like A_UNIQUE_ASSET! that ends in an exclamation mark. It can only be owned by a single address. They might want the ability to send to that address (by the name of the asset). Please check with the creator/funder of this issue to ensure these assumptions are correct.

@TronBlack TronBlack added the gitcoin_funded Funded by gitcoin label Mar 24, 2021
@gitcoinbot
Copy link

@surajsingla333 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gitcoin_funded Funded by gitcoin
Projects
None yet
Development

No branches or pull requests

4 participants