Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create character input event emits 'create-player' #2

Open
seanohue opened this issue Jun 18, 2020 · 1 comment
Open

Create character input event emits 'create-player' #2

seanohue opened this issue Jun 18, 2020 · 1 comment

Comments

@seanohue
Copy link
Contributor

Describe the bug
When the user should be re-prompted during the create-character input event, it emits create-player instead of its own event name.

To Reproduce
Try entering a character name that is already used.

Expected behavior
I would expect to be prompted again. Instead, I'm fairly certain it hangs and the player has to disconnect.

Environment (please complete the following information):

  • OS: MacOS
  • Node version v12 LTS
@azigler
Copy link

azigler commented Jun 19, 2020

Nice catch on this one. There are 3 references to create-player instead of create-character that need to be fixed in this file. As well, there are some references to the say function which I assume are leftovers from when this input-event used Broadcast on the main project repository. Those should be swapped out with socket.write, but don't forget to include \r\n at the end of the string in each call to socket.write to make sure you get the necessary line breaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants