Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment on Room Exits not correct #63

Open
markscho opened this issue Mar 13, 2019 · 1 comment
Open

Comment on Room Exits not correct #63

markscho opened this issue Mar 13, 2019 · 1 comment
Labels
good first issue Good for newcomers

Comments

@markscho
Copy link
Contributor

core/src/Room.js

Line 12 in 4f42494

* @property {Array<object>} exits Exits out of this room { id: number, direction: string }

It's not "id: number". It should be "roomId: string"
@shawncplus shawncplus added the good first issue Good for newcomers label Aug 22, 2019
azigler added a commit to azigler/core that referenced this issue Jun 5, 2020
@azigler
Fix RanvierMUD#63
021ea21
azigler added a commit to azigler/core that referenced this issue Jun 6, 2020
@azigler
Fix RanvierMUD#63
90e99f8
azigler added a commit to azigler/core that referenced this issue Jun 6, 2020
@azigler
Revert "Fix RanvierMUD#63"
023b703 
This reverts commit 021ea21.
@azigler
Copy link

azigler commented Jun 7, 2020

I've addressed this in #121.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shawncplus @azigler @markscho