only check for new instance when entering from a different area #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise moving around within the instance fires off new instances
seanohue
reviewed
Oct 18, 2019
| @@ -157,12 +157,14 @@ function getRoom(state, player, nextRoomId) { | |||
| let nextRoom = null; | |||
| if (state.AreaFactory.isInstanced(nextAreaName)) { | |||
| const instanceId = player.name; | |||
| B.sayAt(player, `Entering instanced area: ${nextAreaName}`); | |||
| if (player.area != nextAreaName ){ | |||
There was a problem hiding this comment.
Some of the spacing here is a bit off, and it is best practice to use !== (though I am not sure this would cause issues unless the area names were undefined/null/0/''...
There was a problem hiding this comment.
Whats the best way for me to edit the pull request? do I just need to submit another one?
There was a problem hiding this comment.
Nah, you can edit it using GitHub's UI, or you can use Git to pull down the branch, edit it locally, and then push it to the same remote branch.
|
This is a good catch and should be merged into the instancing branch if possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise moving around within the instance fires off new instances