Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have comma interpreted as AND on command parser #1

Open
marcelomoreli opened this issue Aug 30, 2017 · 2 comments
Open

Have comma interpreted as AND on command parser #1

marcelomoreli opened this issue Aug 30, 2017 · 2 comments
Assignees

Comments

@marcelomoreli
Copy link

Can you please implement the commandParser so that it can accept multiple keywords to use as AND condition?

Example: "get long,sword" would get the items that have both 'long' and 'sword'.
"kill fire,mage" in a room that has "ice mage, fire mage, fire monster" would get the NPC named "fire mage", and so on.

@marcelomoreli
Copy link
Author

marcelomoreli commented Aug 30, 2017

As part of this issue, can you please also fix it so that it doesn't look for any part of the argument in the name?
Example: Right now look ood will find the "Wooden Chest". Even look t will find the Wooden Chest.

Can we make it so that it only returns if the keywords STARTS with the args?
Examples related to "Wooden Chest"
look o -> Will not find it
look w -> will find it
look wo -> will find it
look c -> will find it
look est -> will not find it
look w,e -> will not find it
look w,c -> will find it
look woo,ch -> will find it

@shawncplus shawncplus self-assigned this Aug 30, 2017
@seanohue
Copy link

These are both cool fixes/improvements, good call.

marcelomoreli referenced this issue in marcelomoreli/ranviermud Nov 23, 2017
Implementing comma as AND and also considering only when keyword/name starts with the word.
@shawncplus shawncplus transferred this issue from RanvierMUD/ranviermud Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants