Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New PostgreSQL 16 changes break compilation #71

Open
karpov-sv opened this issue Oct 28, 2023 · 0 comments
Open

New PostgreSQL 16 changes break compilation #71

karpov-sv opened this issue Oct 28, 2023 · 0 comments

Comments

@karpov-sv
Copy link
Contributor

Just to keep track of things - recently (since PG16?..) they split some definitions from postgres.h into varatt.h. The following changes are necessary to compile RTS2:

diff --git a/src/pgsql/pg_wcs.c b/src/pgsql/pg_wcs.c
index 8570795fe..dc61fca75 100644
--- a/src/pgsql/pg_wcs.c
+++ b/src/pgsql/pg_wcs.c
@@ -21,6 +21,7 @@
 
 #include <postgres.h>
 #include <fmgr.h>
+#include <varatt.h>
 #ifdef PG_MODULE_MAGIC
 PG_MODULE_MAGIC;
 #endif
diff --git a/src/pgsql/pg_wcs2.c b/src/pgsql/pg_wcs2.c
index 62ef7d096..9b5d1f29a 100644
--- a/src/pgsql/pg_wcs2.c
+++ b/src/pgsql/pg_wcs2.c
@@ -21,6 +21,7 @@
 
 #include <postgres.h>
 #include <fmgr.h>
+#include <varatt.h>
 #ifdef PG_MODULE_MAGIC
 PG_MODULE_MAGIC;
 #endif

I don't know how to properly wrap the fix so that it still compiles on older versions (where this new header is absent), so will just leave it here for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant