Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3D Group Convolution BWD and Weight Update passes fail when pads and strides are not all 1s #1070

Closed
amberhassaan opened this issue Nov 30, 2023 · 6 comments
Closed

3D Group Convolution BWD and Weight Update passes fail when pads and strides are not all 1s #1070

amberhassaan opened this issue Nov 30, 2023 · 6 comments
Assignees
@bartekxk

Comments

@amberhassaan
Copy link
Contributor

Please see ROCm/MIOpen#2560

I will debug this further to establish if the fault lies on the MIOpen side, but opening this issue in case it's a CK bug.

CC: @JehandadKhan , @junliume , @zjing14 , @iq136boy
@zjing14
Copy link
Contributor

zjing14 commented Dec 4, 2023

@bartekxk Could you take a look?

@bartekxk
Copy link
Contributor

The problem was caused by a bug in MIOpen.

@junliume
Copy link
Contributor

@bartekxk have we communicated the bug and whether it is fixed in MIOpen with @amberhassaan ?

@amberhassaan
Copy link
Contributor Author

@junliume : Yes, @bartekxk helped me identify the issue (lengthy process of comparing things on MIOPen and CK sides) and I will cleanup my code and push a fix to MIOpen PR 2560 referenced in the description.

@atamazov
Copy link

FYI https://github.com/ROCm/MIOpen/pull/2373/files#r1425955983

@bartekxk
Copy link
Contributor

@atamazov Good point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bartekxk bartekxk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@amberhassaan @zjing14 @junliume @atamazov @bartekxk