Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle situations where bonds (or equity) data is missing #55

Closed
jdhoffa opened this issue Dec 28, 2024 · 0 comments · Fixed by #56
Closed

handle situations where bonds (or equity) data is missing #55

jdhoffa opened this issue Dec 28, 2024 · 0 comments · Fixed by #56

Comments

@jdhoffa
Copy link
Member

jdhoffa commented Dec 28, 2024

It is possible that the datasets Bonds_results_portfolio.rds, Equity_results_portfolio.rds (or both) do not exist.

Currently, if that is the case, the dashboard generation process will error out entirely:

equity_results_portfolio <- readRDS(file.path(analysis_output_dir, "Equity_results_portfolio.rds"))
bonds_results_portfolio <- readRDS(file.path(analysis_output_dir, "Bonds_results_portfolio.rds"))
equity_results_company <- readRDS(file.path(analysis_output_dir, "Equity_results_company.rds"))
bonds_results_company <- readRDS(file.path(analysis_output_dir, "Bonds_results_company.rds"))

The prepare_pacta_dashboard_data should handle situations where these datasets are not available gracefully.

In particular, it should try to prepare every dataset that it can. If an input dataset is unavailable, it should warn, but continue with the preparation process.

If it cannot prepare a particular output dataset, it should warn but proceed.

@AlexAxthelm AlexAxthelm linked a pull request Jan 3, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant