Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upkeep: Don't depend on r2dii.data for unit tests #472

Open
jdhoffa opened this issue Feb 6, 2024 · 0 comments
Open

upkeep: Don't depend on r2dii.data for unit tests #472

jdhoffa opened this issue Feb 6, 2024 · 0 comments
Labels
feature a feature request or enhancement

Comments

@jdhoffa
Copy link
Member

jdhoffa commented Feb 6, 2024

What this is likely to look like in practice is:

  • Removing all regression tests for adequately tested functions (what does adequately tested mean?)
  • May end up being a dangerous change, but I think a desirable one

@AlexAxthelm do you have any experience or knowledge around how to ensure a "safe removal" of a regression test? Or rather, ensuring that the function has adequate test coverage prior to doing so?

AB#9906

@jdhoffa jdhoffa added the feature a feature request or enhancement label Feb 6, 2024
@jdhoffa jdhoffa added ADO Maintenance Day! and removed ADO Maintenance Day! labels Feb 19, 2024
@jdhoffa jdhoffa changed the title Don't depend on r2dii.data for regression tests Don't depend on r2dii.data for unit tests Mar 14, 2024
@jdhoffa jdhoffa changed the title Don't depend on r2dii.data for unit tests upkeep: Don't depend on r2dii.data for unit tests Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant