-
Notifications
You must be signed in to change notification settings - Fork 1
Inter-rack slice with stitching port does not show manifest correctly in Flukes #133
Comments
Thanks,
Please deploy it. I can play with it by manually modifying the manifest.
…-Yufeng
On May 18, 2017, at 1:52 PM, Ilya Baldin ***@***.***> wrote:
OK, I have to apologize - the Flukes version that supposedly had the NdlPath fix actually did not - I ignored POM version dependencies when rebuilding Flukes. Now that I'm using the actual test version, the ts-2-9 case displays correctly with no changes. So I can deploy this version of Flukes as production and things should work.
For mp-st-2 case above things aren't quite as rosy. It displays the following figure:
<https://cloud.githubusercontent.com/assets/12304033/26216213/4493ae6a-3bd1-11e7-9b4d-228e9ad63674.png>
I'm investigating.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub <#133 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHPA5hUP2tusj5KwDEvFprTRl2Xq0vcLks5r7IV2gaJpZM4Nbxqz>.
|
Done (same location) Try it on the ts-2-9 first. If it works for that, it's the right version. |
Per discussion with @YufengXin we are going to leave the version of flukes in the 'new' configuration and Yufeng will work to get rid of unnecessary / interfaces on stitchport and VLAN entities that are confusing the pathfinding logic. |
Should I update the 'production' version of Flukes to this as well, or not? |
This has to do with extra / interfaces that provide an incorrect path from stitchport to node. @YufengXin is looking at possible solutions. |
Some additional examples from Paul: simple.stitchport.manifest.txt |
I'm not sure if this is relevant to the problem, but in the mp-st-2 manifest, the wsuNet:
bbnNet:
The same potential discrepancy is exhibited in the simple.stitchport.manifest.txt file too. Should VLANs connected to StitchPorts have three |
There are two things that I have been looking at, the In the TS2-9 case, there is still the problem where it seems to be random whether or not the Stitchport will be connected to the rest of the graph. mp-st-2I modified the provided mp-st-2-manifest to include the third
simple.stitchportI modified the provided simple.stitchport.manifest to include the extra
TS2-9I started writing a test case that looks at the manifest. I print out the manifest into temp files, so that I can review them in flukes. This is two consecutive runs of the test case, with the same code, producing manifest that are effectively the same, but with different random GUIDs, etc. As you can see, in one case the graph/Stitchport is fully connected, and in one case it is not. It is potentially interesting that there is no 'double' link in evidence, as there is in the simple-stitchport example. TS2-9.rdf-manifest-6561746094323557689.rdf.txt
TS2-9.rdf-manifest-5450746101034930766.rdf.txt
|
Need to check by running Flukes in Eclipse to see how the structure of manifest can be changed to be properly connected [Ilya] |
There are two cases - when stitchport is defined in XXXNet site vs when it is defined directly on ION.
|
So the issue appears to be the structure of a path to stitchport vs a structure of the path to regular node. It isn't wrong in either case, but it is different. I have code that after the path is reconstructed out of RDF entities (it includes, nodes and links) walks the sequence throwing away links and connecting the nodes). In the case of node-to-node path I can simply skip every other step without checking and it works. In the case of a stichport there seems to be an extra element that needs to be skipped. I need to look closer and talk to Yufeng to make sure my fix is correct, but this should be a straightforward fix within Flukes without messing with ORCA code. |
This was fixed in RENCI-NRIG/flukes#15 |
For mp-st-2-manifest.rdf.txt Flukes fails to properly derive a path from VLAN3 to the stitchport:
Notice path to Stitchport is only of length 3 and it skips the ion node completely. I'm looking at the path logic under orca.ndl to see if it can be fixed easily, but this is a model problem. |
@ibaldin would you pls modify the attached manifest files to make them show correctly at Flukes, then I will try to generate the right RDF accordingly? I tried manually modifying the RDF, but could not make them work.
The inter-rack MP case maybe useful because the two VM branches show correctly.
ts-2-9.rdf.txt
ts-2-9-manifest.rdf.txt
mp-st-2.rdf.txt
mp-st-2-manifest.rdf.txt
The text was updated successfully, but these errors were encountered: