Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Disable linting from the qwik optimizer #190

Open
shairez opened this issue Nov 14, 2024 Discussed in #188 · 0 comments
Open

RFC: Disable linting from the qwik optimizer #190

shairez opened this issue Nov 14, 2024 Discussed in #188 · 0 comments
Assignees
@wmertens
Labels
[STAGE-2] incomplete implementation Remove this label when implementation is complete [STAGE-2] not fully covered by tests yet Remove this label when tests are verified to cover the implementation [STAGE-2] unresolved discussions left Remove this label when all critical discussions are resolved on the issue [STAGE-3] docs changes not added yet Remove this label when the necessary documentation for the feature / change is added [STAGE-3] missing 2 reviews for RFC PRs Remove this label when at least 2 core team members reviewed and approved the RFC implementation

Comments

@shairez
Copy link
Contributor

shairez commented Nov 14, 2024

Discussed in #188

Originally posted by wmertens November 6, 2024

What is it about?

linting

What's the motivation for this proposal?

Problems you are trying to solve:

Right now, by default, we lint files in dev mode. This slows down the build, especially on large projects.

Proposed Solution / Feature

What do you propose?

Remove linting from the plugin:

  • IDEs have linting during editing
  • if something breaks, it's obvious
  • the build has a separate lint step anyway
  • we only support eslint, not biome or whatever
  • if someone wants this, they can install a plugin like https://github.com/nabla/vite-plugin-eslint

Links / References

QwikDev/qwik#6837
@github-project-automation github-project-automation bot moved this to In Progress (STAGE 2) in Qwik Evolution Nov 14, 2024
@github-actions github-actions bot added [STAGE-2] incomplete implementation Remove this label when implementation is complete [STAGE-2] not fully covered by tests yet Remove this label when tests are verified to cover the implementation [STAGE-2] unresolved discussions left Remove this label when all critical discussions are resolved on the issue [STAGE-3] docs changes not added yet Remove this label when the necessary documentation for the feature / change is added [STAGE-3] missing 2 reviews for RFC PRs Remove this label when at least 2 core team members reviewed and approved the RFC implementation labels Nov 14, 2024
@shairez shairez moved this from Backlog to Upcoming in Qwik Development Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wmertens wmertens

Labels
[STAGE-2] incomplete implementation Remove this label when implementation is complete [STAGE-2] not fully covered by tests yet Remove this label when tests are verified to cover the implementation [STAGE-2] unresolved discussions left Remove this label when all critical discussions are resolved on the issue [STAGE-3] docs changes not added yet Remove this label when the necessary documentation for the feature / change is added [STAGE-3] missing 2 reviews for RFC PRs Remove this label when at least 2 core team members reviewed and approved the RFC implementation
Projects
Qwik Development
Status: Upcoming
Qwik Evolution
Status: In Progress (STAGE 2)
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wmertens @shairez