Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Issues with the rewrite #55

Open
sleepy-evelyn opened this issue Sep 11, 2023 · 6 comments
Open

UI Issues with the rewrite #55

sleepy-evelyn opened this issue Sep 11, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@sleepy-evelyn
Copy link

sleepy-evelyn commented Sep 11, 2023

Operating System

IpadOS & MacOS

Web Browser

Safari & Opera

Issue description

For screens that are larger than a phone but smaller than a desktop or laptop computer like a tablet, there is a significant amount of wasted space with the sidebar. Ideally, the sidebar should scale depending on the screen width but a quick fix at least is to reduce the width of the sidebar for now as it's way too wide already.

Screenshot_2023-09-11_at_18 20 09

The font for code snippets is also abnormally large compared to the rest of the text which sticks out quite a bit.

Screenshot 2023-09-11 at 18 27 19

Finally, this is more nitpicking but having a small menu button for mobile devices is a bit weird. Ideally this should stretch the width of the screen

Screenshot 2023-09-11 at 18 29 32
@sleepy-evelyn sleepy-evelyn added the bug Something isn't working label Sep 11, 2023
@sleepy-evelyn
Copy link
Author

sleepy-evelyn commented Sep 11, 2023

I'll include the fabric wiki as an example for comparison since despite the kind of minimal design they do a good job of scaling depending on the type of device and making proper use of space.

Screenshot 2023-09-11 at 18 39 04

Similarly you can see the menu button is scaled to fit the full length of the screen

Screenshot 2023-09-11 at 18 38 52

@sleepy-evelyn
Copy link
Author

More issues. Code blocks push right up against the contents making it look like they are going under it. Padding is definitely needed

Screenshot 2023-09-15 at 10 28 58

@sleepy-evelyn
Copy link
Author

sleepy-evelyn commented Sep 15, 2023

Messed about with inspect element and came up with this design. Fixes most if not all the problems listed here

image

@sleepy-evelyn
Copy link
Author

sleepy-evelyn commented Sep 15, 2023

Some more suggested sidebar improvements. Just using google material icons. Idk if the licenses are compatible but it looks neat at least.
To implement in a simple way u could define a new icon input for the +category.yml file like so

name: pizza section
icon: local_pizza
Screenshot 2023-09-15 at 13 33 50

@sleepy-evelyn
Copy link
Author

More issues. Code blocks push right up against the contents making it look like they are going under it. Padding is definitely needed

Screenshot 2023-09-15 at 10 28 58

This is now fixed in PR #58

@sleepy-evelyn
Copy link
Author

The padding issue is semi-fixed. Still don't understand why any padding is needed at all but meh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant