Fix for result validation; Error in usage example

[J-C-Q]

When running the usage example from the docs, there is an error when downloading the result.

Fixed it by adding meas_level and curc_id keys to the ExpResult schema.

[Roger-luo]

LGTM, thanks!

[Roger-luo]

just to understand the change better cuz there are a lot format changes, is this the main update of the result schema?

[J-C-Q]

Yes, correct. Sorry for the formatting...

[Roger-luo]

LGTM, thanks! just need to wait for CI pass.

[Roger-luo]

It seems the records are too old, causing CI to fail. Could you also update the records via https://github.com/JuliaTesting/BrokenRecord.jl ?

[J-C-Q]

I want to try, but I'm not familiar with that.

So basically, I need to update the test/records/result.json with the content of the result.json I get from the usage example job, correct? However, they are very different, I'm guessing it's just the "body"?

[J-C-Q]

Or do I have to delete the file to let it generate again?

Seems like I'm not authorized. But maybe the CI bot is?

[Roger-luo]

Yes, first replace the key with your own, and delete all the old files, the BrokenRecord should generate the new files for you, replace the key with the fake one.

[J-C-Q]

While trying to get this to work (I’m struggling a bit, maybe I need to ask some more questions later...), I noticed that the test for the menu doesn't work because it requires stdin to be a TTY (but it is an IOStream during the test). How do you say we proceed with that?

[Roger-luo]

I noticed that the test for the menu doesn't work because it requires stdin to be a TTY (but it is an IOStream during the test). How do you say we proceed with that?

Hmm, that's strange I wrote it the same way how stdlib test it. But I think we can mark this @test_broken first in this PR since it's irrelevant

[J-C-Q]

Alright.
So for the records, I noticed that the test account has different properties than my account, e.g., the URLs. My account doesn't have the -qcon. This way I can't just replace the submit-, status- and result.json since the request will be to a different URL during the playback with the test account. Should I create a new test account to also regenerate account.json etc., since I would rather not use my data for the account info tests?

[Roger-luo]

So for the records, I noticed that the test account has different properties than my account, e.g., the URLs. My account doesn't have the -qcon. This way I can't just replace the submit-, status- and result.json since the request will be to a different URL during the playback with the test account. Should I create a new test account to also regenerate account.json etc., since I would rather not use my data for the account info tests?

You don't need to create an account, that test account is fake as well. You just need to generate the record and then replace the account info in the test manually using grep. So that there is no valid credentials created in the CI

[J-C-Q]

Thank you for the help and your time!

I created a new pull request that should work. #8

[Roger-luo]

closed by #8