Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible deadlocks if Python can't spawn threads #27

Open
ngoldbaum opened this issue Feb 7, 2025 · 0 comments
Open

Possible deadlocks if Python can't spawn threads #27

ngoldbaum opened this issue Feb 7, 2025 · 0 comments

Comments

@ngoldbaum
Copy link
Contributor

Looking at the code, I think the plugin is susceptible to the deadlock I describe here: Quansight-Labs/free-threaded-compatibility#133

I think we need to put this block inside a try/except BaseException:

pytest-run-parallel/src/pytest_run_parallel/plugin.py

Lines 81 to 82 in 0324591

for worker in workers:
worker.start()

and explicitly abort the barrier in the error case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ngoldbaum