Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MySQL why use --skip-extended-insert? #117

Open
moisesrodriguez opened this issue May 17, 2022 · 4 comments
Open

MySQL why use --skip-extended-insert? #117

moisesrodriguez opened this issue May 17, 2022 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@moisesrodriguez
Copy link

Looking at how mysqldump is used, I noticed the flag --skip-extended-insert. Why write INSERT statements using one-row syntax that includes only one record in one statement, if it will be much much slower than having multiple records in one INSERT statement? Specially when importing a lot of data.

@fabriceclementz
Copy link
Contributor

Hi @moisesrodriguez
This flag was added so that the final dump is as close as possible to that of PostgreSQL, the reason being that it was easier to parse without major change in the dump parser for assuring a compatibility with MySQL.
Indeed, this has a performance impact but this will be changed in a future release, the objective being to have the most efficient tool possible.

Contributions are welcome to improve the tool.

@evoxmusic
Copy link
Contributor

Hey @moisesrodriguez (happy to see you here :)) It's related to this #36
Once we'll fix it for PSQL, it would be easy to port that change to MySQL. As @fabriceclementz said, feel free to contribute if you have some time. I don't think it's a big deal, to be honest, just a matter of 2 to 3 hours of work (tests included).

@evoxmusic evoxmusic added duplicate This issue or pull request already exists enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed and removed duplicate This issue or pull request already exists labels May 17, 2022
@fabriceclementz
Copy link
Contributor

Hi @evoxmusic
This is the next issue I will try to tackle, As COPY for Postgres, This will considerably improve the performance of Replibyte, I let you know my progress.

@evoxmusic
Copy link
Contributor

Thank you @fabriceclementz - it's definitely a must have improvement to increase restore performances. I am also looking how we can better bench and watch Replibyte performances

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants