Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate functions which refer to integer configuration representations as addresses #30

Closed
caleb-johnson opened this issue Sep 16, 2024 · 2 comments
Closed

Deprecate functions which refer to integer configuration representations as addresses #30

caleb-johnson opened this issue Sep 16, 2024 · 2 comments
Labels
enhancement New feature or request
Milestone
0.6.0

Comments

@caleb-johnson
Copy link
Collaborator

caleb-johnson commented Sep 16, 2024 •
edited
Loading

What should we add?

This is not the correct usage of the term, addresses, as used by PySCF. Let's give these functions better names (strings or CI strings maybe?)

After merging #23 , there may just be one function left, fermion.bitstring_matrix_to_sorted_addresses.
@caleb-johnson
Copy link
Collaborator Author

CC: @kevinsung

@caleb-johnson caleb-johnson added the enhancement New feature or request label Sep 18, 2024
@caleb-johnson caleb-johnson added this to the 0.6.0 milestone Sep 20, 2024
@caleb-johnson caleb-johnson changed the title Deprecate functions which refer to base-10 configuration representations as addresses Deprecate functions which refer to integer configuration representations as addresses Sep 24, 2024
@caleb-johnson
Copy link
Collaborator Author

Closed by #54

@caleb-johnson caleb-johnson mentioned this issue Sep 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
1 participant
@caleb-johnson