Add checkVector test helper equivalent to checkMatrix, NativePrint for std::unordered_map and std::array #5293
Conversation
| { | ||
| bool result; | ||
| std::string result_message; | ||
| }; |
There was a problem hiding this comment.
Can we use empty return error_message for pass instead of this two element struct? Just return the error_string.
There was a problem hiding this comment.
I'm not a big fan of check for null as success semantics and this turns out quite readable with the catch macros for checkMatrix. I want this to have the same semantics. See: test_ConstantSPOSet.cpp, test_cuBLAS_LU.cpp, test_spline_applyrotation.cpp, etc.
There was a problem hiding this comment.
The current CheckXXXResults is not concise.
If results=true, it is unclear what non-empty result_message should be used for or should I care?
If results=false, but results_message is empty. Should I concerned about an empty result_message? Is that a bug?
I don't like undefined behvaviors.
A single string is neat. If empty, pass. If non-empty, error info is given.
Do you have good ways to prevent any UB with CheckXXXResults?
|
test this please |
PDoakORNL
force-pushed
the
more_testing_utilities
branch
from
52acdd8 to
b802536
Compare
Expanded Utilities/for_testing.
Proposed changes
See title
Incoming PR's will have tests that use these and provide coverage.
What type(s) of changes does this code introduce?
Delete the items that do not apply
Does this introduce a breaking change?
What systems has this change been tested on?
Checklist