Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build recipe for polaris and aurora #5279

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

Hyeondeok-Shin
Copy link
Contributor

Please review the developer documentation
on the wiki of this project that contains help and requirements.

Proposed changes

As CMake option is updated on #5267, Build recipes for Polaris and Aurora need to be updated with removing unnecessary options and simplifying their build names.

What type(s) of changes does this code introduce?

  • Documentation or build script changes

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

Polaris, Aurora

Checklist

Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.

  • Yes. This PR is up to date with current the current state of 'develop'
  • No. Code added or changed in the PR has been clang-formatted
  • No. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • No. Documentation has been added (if appropriate)

@ye-luo
Copy link
Contributor

ye-luo commented Jan 14, 2025

Please update the last verified dates at the top of these scripts.

Copy link
Contributor

@ye-luo ye-luo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Noting that it we should add a mention of Aurora after https://github.com/QMCPACK/qmcpack/blob/develop/docs/installation.rst#installing-on-alcf-polaris . This section and config also needs some cleanup for decommissioned machines.

@prckent
Copy link
Contributor

prckent commented Jan 14, 2025

Test this please

@prckent prckent enabled auto-merge January 14, 2025 15:37
@prckent prckent merged commit 7086c88 into QMCPACK:develop Jan 14, 2025
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants