Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Property name "healthCare" is not consistent with the spelling #68

Open
tom-at-moverly opened this issue Jun 15, 2023 · 1 comment
Open

Property name "healthCare" is not consistent with the spelling #68

tom-at-moverly opened this issue Jun 15, 2023 · 1 comment

Comments

@tom-at-moverly
Copy link
Collaborator

tom-at-moverly commented Jun 15, 2023 •
edited
Loading

The term healthcare is one word and also referred to the schema, for example "Nearby healthcare services". Should the property name be healthcare instead of camel casing it as two words?

https://github.com/Property-Data-Trust-Framework/schemas/blob/805b17bc5dab32e80b6553636d7b01feeeb15715/src/schemas/v2/pdtf-transaction.json#L655
@vivek656
Copy link
Collaborator

vivek656 commented Aug 4, 2023

this is a relatively new field addition, but changing the field name is a breaking change.
it needs a separate pr, and a proper version upgrade
@amolpednekar @edmolyneux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vivek656 @tom-at-moverly