Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

titlesToBeSold.registerExtract.ocSummaryData.propertyAddress should be an array #179

Open
jacknely opened this issue Apr 10, 2024 · 0 comments · Fixed by #189
Open

titlesToBeSold.registerExtract.ocSummaryData.propertyAddress should be an array #179

jacknely opened this issue Apr 10, 2024 · 0 comments · Fixed by #189
Assignees

Comments

@jacknely
Copy link
Collaborator

jacknely commented Apr 10, 2024

This needs to be an array as some title responses have more than one addressLine objects:

example:
[{“postcodeZone”: {“postcode”: “M40 9PL”}, {'addressLine': {'line': ['2 William Prance Road']}}, {'addressLine': {'line': ['bin store']}}]

The XML to JSON library that we use correctly parses this to an array but I'm ok with adding some custom logic to concat all addressLine objects to one if we want maintain true backwards compatibility with schema.

https://github.com/Property-Data-Trust-Framework/schemas/blob/ff9eaa88b75338e165cda2b5d911302c3c532ec3/src/schemas/v3/pdtf-transaction.json#L25666

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant